Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): video style in edgeless #10198

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Feb 14, 2025

Before

Screenshot 2025-02-14 at 17.51.29.png

After

Screenshot 2025-02-14 at 17.51.46.png

Copy link
Contributor Author

fundon commented Feb 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review February 14, 2025 09:51
@fundon fundon requested a review from a team as a code owner February 14, 2025 09:51
@graphite-app graphite-app bot requested review from a team February 14, 2025 09:52
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (f369a8d) to head (6dc1fef).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10198      +/-   ##
==========================================
+ Coverage   54.04%   54.33%   +0.28%     
==========================================
  Files        2327     2327              
  Lines      107082   107082              
  Branches    17744    17790      +46     
==========================================
+ Hits        57873    58178     +305     
+ Misses      47883    47575     -308     
- Partials     1326     1329       +3     
Flag Coverage Δ
server-test 79.05% <ø> (+0.76%) ⬆️
unittest 31.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon changed the base branch from fundon/02_14_improve_AttachmentEmbedService to graphite-base/10198 February 15, 2025 05:18
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from e1117f8 to 978352c Compare February 15, 2025 05:18
@fundon fundon force-pushed the graphite-base/10198 branch from 6ac9c4c to 0e29590 Compare February 15, 2025 05:18
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from 978352c to b65cb4a Compare February 15, 2025 06:36
@fundon fundon force-pushed the graphite-base/10198 branch 2 times, most recently from 7deecf6 to 8e0ab6b Compare February 17, 2025 01:22
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from b65cb4a to b4274ec Compare February 17, 2025 01:22
@fundon fundon force-pushed the graphite-base/10198 branch from 8e0ab6b to 31c9a8e Compare February 17, 2025 01:25
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from b4274ec to ea94268 Compare February 17, 2025 01:25
@fundon fundon force-pushed the graphite-base/10198 branch from 31c9a8e to 0495af7 Compare February 17, 2025 01:32
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from ea94268 to 71aa9af Compare February 17, 2025 01:32
@fundon fundon force-pushed the graphite-base/10198 branch from 0495af7 to 50f7db1 Compare February 17, 2025 03:48
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch 2 times, most recently from 180976c to c1a0b06 Compare February 17, 2025 04:35
@fundon fundon force-pushed the graphite-base/10198 branch from 50f7db1 to 378007d Compare February 17, 2025 04:35
@fundon fundon changed the base branch from graphite-base/10198 to canary February 17, 2025 04:36
@fundon fundon force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from c1a0b06 to 280a26c Compare February 17, 2025 04:36
@graphite-app graphite-app bot force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from 280a26c to 8f6ebc3 Compare February 17, 2025 04:56
Copy link

graphite-app bot commented Feb 17, 2025

Merge activity

  • Feb 17, 12:09 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test (2, 3)').
  • Feb 17, 1:46 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 17, 2:03 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Legacy Blocksuite E2E Test (3)').
  • Feb 17, 2:25 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 17, 2:26 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the fundon/02_15_fix_video_style_in_edgeless branch from 7c29e2e to 6dc1fef Compare February 17, 2025 06:50
@graphite-app graphite-app bot merged commit 6dc1fef into canary Feb 17, 2025
66 checks passed
@graphite-app graphite-app bot deleted the fundon/02_15_fix_video_style_in_edgeless branch February 17, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants